New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile #461
base: master
Are you sure you want to change the base?
Add Dockerfile #461
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution.
Content looks alright to me. I have some minor comments:
- Please add a section in the README.md, maybe under the
Installation
section asBuilding on Docker
. - The Dockerfile doesn't have an ENTRYPOINT or CMD (which is fine), so the documentation should also note examples on how to use the two binaries being built inside this Dockerfile
README.md: I think rusty-kaspa is a better tag A few suggestions on changes to the Dockerfile based on Docker best practices:
EDIT: Revised the comment about ENTRYPOINT |
No description provided.