Added a copy constructor

[biancama]

Hi I added a copy constructor because to mitigate the side effect all arithmetic operations

[kasparsklavins]

Ignore the failing checks.
What kind of side effects?

[biancama]

which failing tests?

basically each time copy the object to return it from a function.

so if I have
Bigint a(10), b, c;
b= a(10);
c = a.pow(2);

then
a = 100 c = 100 but b =10

If I don't have the copy constructor all are 100

normally it's good for this kind of operation having immutability

have a look to
https://docs.oracle.com/javase/7/docs/api/java/math/BigInteger.html

Always return new object

Massimo

On Wed, Jun 15, 2016 at 12:35 PM, Kaspars notifications@github.com wrote:

Ignore the failing tests.
What kind of side effects?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#8 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAbpKeW1GHloHtsWjfS_S8pQW0qdOm3Vks5qL9VpgaJpZM4I2F1g
.

Massimo Biancalani

[kasparsklavins]

These checks.

Thanks for the pull request, will go through it later.