Minimally require Ruby 3.0 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like I just bumped to 2.7 in d9b2b01 back when I wrote the gem. I had accidentally used a Ruby 3.0 syntax feature here https://github.com/kaspth/active_record-associated_object/blob/9b182b3eca357f0c6620dc655005bea1a62e2db0/lib/active_record/associated_object.rb#L18 And forgot to test on 2.7 in CI, meaning that I never caught that the gem can't load on 2.7. So we've effectively been 3.0 exclusive forever, so any users on this are already minimally on 3.0 and I'd rather bump to 3.0 since 2.7 is EOL'ed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like I just bumped to 2.7 in d9b2b01 back when I wrote the gem.
I had accidentally used a Ruby 3.0 syntax feature here
active_record-associated_object/lib/active_record/associated_object.rb
Line 18 in 9b182b3
And forgot to test on 2.7 in CI, meaning that I never caught that the gem can't load on 2.7. So we've effectively been 3.0 exclusive forever, so any users on this are already minimally on 3.0 and I'd rather bump to 3.0 since 2.7 is EOL'ed.