Improve object shape friendliness #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspth
reviewed
Jan 7, 2024
|
I considered that, but didn't want to add a Hash allocation to every single ActiveRecord instance of a model with at least 1 associated object. |
|
Oh, you'd initialize it to |
Co-authored-by: Kasper Timm Hansen <hey@kaspth.com>
|
@kaspth it should be good to go now |
|
Oh, the documentation needs to change too I guess |
kaspth
reviewed
Jan 7, 2024
|
I'll fix up the documentation after merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm mimicking what Jean did here:
rails/rails#47023
rails/rails#47032
rails/rails#47049
Otherwise, if you've got multiple associated objects on a single class, you can end up with a lot of permutations of object shapes because the instance variables are lazily defined in whatever order the associated objects may or may not have been called in.
Author has these 3 instance variables:
@archiver@classified@fortificationThat leaves you with these permutations of object shapes:
@archiver@archiver @classified@archiver @fortification@archiver @classified @fortification@archiver @fortification @classified@classified@classified @archiver@classified @fortification@classified @archiver @fortification@classified @fortification @archiver@fortification@fortification @archiver@fortification @classified@fortification @archiver @classified@fortification @classified @archiverNow, we'll have 1 shape:
@archiver @classified @fortification