Fix: Extensions aren't loaded in development/test #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR kaspth#19 previously loaded the associated object class when the has_object was defined, so that extensions would get run. It seems like that code got lost in a rebase. So now, extensions only run on boot if eager loading is enabled (which it is in production). Otherwise they aren't loaded until the first time the associated object gets used.
|
Ah, can't believe I missed that! Thank you for the PR. I'll ship a new gem release now. |
|
Done. v0.7.1 should is out now. |
|
No problem. I'm confident it got lost in that rebase that happened when you merged my PR and then your PR. Thanks for getting this released! |
|
Yeah, I think you're right about that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #19 previously loaded the associated object class when the has_object was defined, so that extensions would get run. It seems like that code got lost in a rebase. So now, extensions only run on boot if eager loading is enabled (which it is in production). Otherwise they aren't loaded until the first time the associated object gets used.
RE: #19 (comment)