Skip processing already processed files #46
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the hackiest code I've done yet, but I just couldn't do it cleanly for now.
On first run for a file like this:
We both add data in the database and define a
accounts.business
accessor method, but once we've done that, we don't necessarily need to do it again.So now we record the methods we add into
tmp/oaken-result.yml
, and via the file checksum we can see whether we've already processed the file. If we've already processed the file, we can "replay" those previously added methods and add them again.This way we can skip the entire file because the checksum lets us know we've already handled it.
This is kind of at the edge of my ability to do, so I'm planning on sleeping on this and then keep tweaking the design. I'm also sure there's tons of pitfalls with this, it's not easy!