Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in README #59

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fill in README #59

merged 1 commit into from
Oct 31, 2023

Conversation

kaspth
Copy link
Owner

@kaspth kaspth commented Oct 31, 2023

This adds a bunch of information on our conventions and how to set up dev data plus reuse it in tests.

This adds a bunch of information on our conventions and how to set up dev data plus reuse it in tests.
@kaspth
Copy link
Owner Author

kaspth commented Oct 31, 2023

@tcannonfodder does this get to some of what you were saying in #58?

@kaspth kaspth merged commit 889fbc2 into main Oct 31, 2023
2 checks passed
@kaspth kaspth deleted the fill-in-readme branch October 31, 2023 22:59
@tcannonfodder
Copy link
Collaborator

@tcannonfodder does this get to some of what you were saying in #58?

Not quite; I was thinking about how Rails’ generators operate. In short, similar to factorybot or fixtures, if I generate a new model using rails generate model, I would like Oaken to stub out a new file, rather than having Rails generate a fixture I’ll never use

@kaspth
Copy link
Owner Author

kaspth commented Nov 1, 2023

@tcannonfodder ah got it. Yeah, that's interesting. I'm not quite sure where we'd add that data since we don't have a 1-1 mapping of a model to a file. But we could definitely make it so that fixture files aren't generated when you're using Oaken.

@tcannonfodder
Copy link
Collaborator

tcannonfodder commented Nov 1, 2023

That would work! I just wanna make sure my generators are working as expected & don’t make cruft 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants