Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qc_report will only take full path to zipfiles #1

Closed
ACharbonneau opened this issue Apr 14, 2017 · 5 comments
Closed

qc_report will only take full path to zipfiles #1

ACharbonneau opened this issue Apr 14, 2017 · 5 comments

Comments

@ACharbonneau
Copy link

I'm running fastqrc from the folder that contains all the zip files.

qc.path <- "."

Running list.files(qc.path) gives files as expected, and qc <- qc_aggregate(qc.path) gives a valid report, however qc_report(qc.path, result.file = "test") gives:

Quitting from lines 51-53 (multi-qc-report.Rmd)
Error in qc_aggregate(qc.path, progressbar = FALSE) :
Can't find any *fastqc.zip files in the specified qc.dir

Replacing the relative path with a full path to the same directory allows both qc_aggregate and qc_report to run, but requiring full paths limits the program's usability for scripting. This is on an HPC, running R/3.2.0 and pandoc/1.17.3

@kassambara
Copy link
Owner

Hi,

Thank you for pointing this out.

The following code should work:

qc_report(qc.path = getwd(), result.file = "test")

kassambara added a commit that referenced this issue Apr 14, 2017
@kassambara
Copy link
Owner

fixed now! Please, install the latest developmental version and let me know if it works now when using qc.path = "." .

To install:

if(!require(devtools)) install.packages("devtools")
devtools::install_github("kassambara/fastqcr")

@ACharbonneau
Copy link
Author

ACharbonneau commented Apr 14, 2017

Beat me to it. But it doesn't like the getwd solution:

qc_report(qc.path = getwd(), result.file = "test")
Error in qc_report(qc.path = getwd(), result.file = "test") :
unused arguments (qc.path = getwd(), result.file = "test")

Developer version works great though. Thanks!

@kassambara
Copy link
Owner

oh, great! so we can close this issue. Thank you again for pointing this out.

@kassambara
Copy link
Owner

better stable solution to handle relative path added now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants