ggtheme also accepts objects of 'theme' type #11
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes
roxygen2
.styler
package.Major changes
The function now works with
ggtheme
argument of eitherfunction
ortheme
type.Example
Created on 2018-08-28 by the reprex package (v0.2.0.9000).
Rationale
This was done to make it compatible with my function
ggstatsplot::ggcorrmat
(https://github.com/IndrajeetPatil/ggstatsplot/blob/master/R/ggcorrmat.R), which is a wrapper aroundggcorrplot
. All functions in my package have the argumentggtheme
, but I force users to enter atheme
and not afunction
class object. So, out of the need for consistency across functions in a single package, I also wantedggcorrmat
to behave the same way, which is possible only if the underlying function (ggcorrplot::ggcorrplot
) was modified.