Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounding of correlation matrix causes hclust ordering differences in the new version. #14

Open
buddha2490 opened this issue Sep 27, 2018 · 1 comment

Comments

@buddha2490
Copy link

buddha2490 commented Sep 27, 2018

I recently updated the ggcorrplot package to 0.1.2. Running ggcorrplot() on a correlation matrix with the hc.order=T option, the ordering of the heatmap drastically changed compared to the older version. I don't know if this is a bug or intentional, but I thought I should point it out to you. Between the old vs new version, it looks like the only thing updated that could affect this is that you are rounding your correlation matrix. At least in my data, this is making quite a difference in the final results.

@buddha2490 buddha2490 changed the title hclust algorithm implementation change in 0.1.2? Rounding of correlation matrix causes hclust ordering differences in the new version. Sep 27, 2018
@MichelineCampbell
Copy link

I am having the same problem with version 0.1.4. With hc.order = F, a correlation pair of r = -0.27 and p = 0.0549 is excluded (as it should be), but with hc,order = T, this correlation pair is included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants