Update ggforest.R #388
Merged
Update ggforest.R #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corrects the bug that made ggforest not displaying polynomial and spline terms, as seen in #306. Of note, I'm confused about the lines 50-51, which are quite long to compute (because `anova()`) but do not seem to add much information (`terms` remained inchanged in all tests I could do). If they do serve some purpose, maybe it could be abstractized into some optional argument ?
|
Thanks! @kassambara would you merge this pull request? |
kassambara
added a commit
that referenced
this pull request
May 20, 2019
|
Cool, thanks ! @kassambara but what about lines 50-51? Could you tell me why you want to perform anova here? |
|
@pbiecek is the function |
|
@kassambara @DanChaltiel thanks for spotting this but now I do not see why it is needed. I've removed this like and check() is passing, so I will create pull request that removes this line |
pbiecek
added a commit
to pbiecek/survminer
that referenced
this pull request
May 20, 2019
|
ok, thanks! |
kassambara
added a commit
that referenced
this pull request
May 20, 2019
removed unnecessary call to anova() as requested in #388
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the bug that made ggforest not displaying polynomial and spline terms, as seen in #306.
Of note, I'm confused about the lines 50-51, which are quite long to compute (because
anova()) but do not seem to add much information (termsremained inchanged in all tests I could do). If they do serve some purpose, maybe it could be abstractized into some optional argument ?