Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid attempt to use Context.rank in Context.work setter. #232

Closed
eirrgang opened this issue Jul 18, 2019 · 0 comments · Fixed by #233
Closed

Invalid attempt to use Context.rank in Context.work setter. #232

eirrgang opened this issue Jul 18, 2019 · 0 comments · Fixed by #233
Assignees
Labels
bug gmxapi pertains to this repository and the Python module support
Projects

Comments

@eirrgang
Copy link
Collaborator

When the Context.work setter fails to find a factory function for an operation, it tries to issue a log message on only the master rank. But in the current implementation, an MPI communicator is not acquired (if at all) until the work width is known and the Session is launching. This prevents useful handling of the error condition and instead creates a confusing Type error.

We should remove the check from Context.work. It should be implemented in the logging infrastructure instead, anyway.

@eirrgang eirrgang added the gmxapi pertains to this repository and the Python module support label Jul 18, 2019
@eirrgang eirrgang self-assigned this Jul 18, 2019
@eirrgang eirrgang added this to In progress in 0.0.7.4 Jul 18, 2019
eirrgang added a commit that referenced this issue Jul 18, 2019
Remove access to Context.rank in a phase of execution where it is `None` instead of an integer.

Fixes #232
@eirrgang eirrgang added the bug label Jul 18, 2019
eirrgang added a commit that referenced this issue Jul 18, 2019
Remove access to Context.rank in a phase of execution where it is `None` instead of an integer.

Fixes #232
@eirrgang eirrgang moved this from In progress to Done in 0.0.7.4 Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug gmxapi pertains to this repository and the Python module support
Projects
0.0.7.4
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant