Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow full CMake-driven build and install. #61

Merged
merged 3 commits into from
May 30, 2018

Conversation

eirrgang
Copy link
Collaborator

@eirrgang eirrgang commented May 15, 2018

Resolve #60 : allow CMake-driven build and install.

Provide some additional CMake infrastructure to manage the pure Python
items in the package and to find a reasonable install location.

I haven't explored the robustness with respect to unclean build directories
or previous installations. Those could be resolved as separate issues if this
patch is immediately useful to simplify installation on systems with poor
Pypi functionality.

Note: one thing that I probably neglected is to update the .py -> .pyc files.
Another is that I don't think there is sufficient CMake target dependency to
force "configure"d files to be updated in the package staging area.

I don't see a good way to refresh the files in the staging area (build/gmx) without a full CMake reconfigure or a bunch of redundant filenames listed in the CMakeLists.txt, and I don't remember
the exact problem with .pyc files. I think we can just document that if funny things happen, the user
should rm CMakeCache.txt and rerun cmake (I added a cleansing step for the staging area), or, better yet, use a fresh build directory, which is easier to do now. Then we can try not to run tests against the build directory to keep from confusing things or stop using the staging area altogether.

  • force regeneration of .pyc files (rejected)
  • put configured files in a target dependency (rejected)
  • confirm correctness / documentation / BlueWaters idiosyncrasy workarounds.
  • add CTest target?

Fix some typos and provide better documentation for determining or
recalculating Python module install location.
@eirrgang eirrgang added this to In progress in 0.0.6 May 24, 2018
@eirrgang eirrgang merged commit b02b6e5 into kassonlab:devel May 30, 2018
0.0.6 automation moved this from In progress to Done May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
0.0.6
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants