-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(repository): Metadata compression config support for dir writer #556
base: kasten
Are you sure you want to change the base?
Conversation
// TODO(prasad): Get rid of complete block once metadata compression setting is implemented for | ||
// all the prefixes | ||
// For now, exclude this for `k` prefixed metadata. | ||
if contentID.HasPrefix() && contentID.Prefix() != "k" && comp == NoCompression && mp.IndexVersion >= index.Version2 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a constant for dir prefix "k" called objectIDPrefixDirectory
. Can we share that >
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition will be updated as per the recent discussion.
Signed-off-by: Prasad Ghangal <prasad.ganghal@veeam.com>
Signed-off-by: Prasad Ghangal <prasad.ganghal@veeam.com>
Signed-off-by: Prasad Ghangal <prasad.ganghal@veeam.com>
Signed-off-by: Prasad Ghangal <prasad.ganghal@veeam.com>
Signed-off-by: Prasad Ghangal <prasad.ganghal@veeam.com>
Signed-off-by: Prasad Ghangal <prasad.ganghal@veeam.com>
Signed-off-by: Prasad Ghangal <prasad.ganghal@veeam.com>
bb7e7bd
to
b29e3a5
Compare
Signed-off-by: Prasad Ghangal <prasad.ganghal@veeam.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please take into account that I'm not an expert in this particular area.
Blocked on this: #557 |
Overview
This PR adds support to configure metadata compressor for dir type of metadata (metadata with
k
prefix)This PR:
zstd-fastest
as the default compressor for metadata in the policykopia policy
commandsTest plan
zstd-fastest
repo
dir and observe stats. Validate content withk
prefix is compressed withzstd-fastest
s2-default
kopia/internal
directory and view content stats. Validate new metadata is compressed withs2-default
kopia/tests
dirtests
dir and inspect content. New metadata stats should be seen asuncompressed