Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several Improvements #25

Closed
wants to merge 6 commits into from
Closed

Several Improvements #25

wants to merge 6 commits into from

Conversation

Craeckie
Copy link

@Craeckie Craeckie commented Jan 14, 2022

I adapted the code to my own preferences. But it includes fixes, e.g. for #22, that's why I made a PR.

  • Tini: sends TERM signal to all processes, so the container doesn't get killed after the timeout
  • Video compression: much smaller video files. Runs well on my server, but might cause performance issues on small instances
  • Outputs the terminal (from zoomrec.py) to docker
  • Reduce polling: Checking every second put some unnecessary load on my server

Feel free to cherry-pick

@bakkerrs bakkerrs mentioned this pull request Feb 24, 2022
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Mar 1, 2022
@kastldratza kastldratza removed the Stale label Mar 7, 2022
@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Apr 22, 2022
@github-actions
Copy link

github-actions bot commented May 3, 2022

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this May 3, 2022
@v1nc
Copy link
Contributor

v1nc commented May 7, 2022

Add a flag for video compression and merge :)

@kastldratza kastldratza removed the Stale label May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants