Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

replace testsuite to testify part 3(set) #48

Merged
merged 1 commit into from Aug 22, 2018

Conversation

chyroc
Copy link
Collaborator

@chyroc chyroc commented Aug 22, 2018

Pull Request for issue

#20

Description

  • replace testsuite to testify
  • fix set package
  • replace some ContainsElements to ElementsMatch
  • replace some ContainsElements to Subset and exchange args order

1 ContainsElements

and for func ContainsElements(t *testing.T, expected []string, given []string) in github.com/kasvith/kache/pkg/testsuite mean:

every elem in expected should in given slice

2 ElementsMatch

func (a *Assertions) ElementsMatch(listA interface{}, listB interface{}, msgAndArgs ...interface{}) bool in github.com/stretchr/testify/assert mean:

// ElementsMatch asserts that the specified listA(array, slice...) is equal to specified
// listB(array, slice...) ignoring the order of the elements. If there are duplicate elements,
// the number of appearances of each of them in both lists should match.

3 Subset

func (a *Assertions) Subset(list interface{}, subset interface{}, msgAndArgs ...interface{}) bool in github.com/stretchr/testify/assert mean:

// Subset asserts that the specified list(array, slice...) contains all
// elements given in the specified subset(array, slice...).

@codecov
Copy link

codecov bot commented Aug 22, 2018

Codecov Report

Merging #48 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   80.15%   80.15%           
=======================================
  Files           8        8           
  Lines         504      504           
=======================================
  Hits          404      404           
  Misses        100      100

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3905925...39fd355. Read the comment docs.

@kasvith kasvith merged commit cf27b3d into kasvith:master Aug 22, 2018
@chyroc chyroc deleted the replace-testsuite-to-testify-part-3 branch August 23, 2018 01:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants