Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

fix/recoverable errors #68

Merged
merged 4 commits into from
Aug 25, 2018
Merged

fix/recoverable errors #68

merged 4 commits into from
Aug 25, 2018

Conversation

kasvith
Copy link
Owner

@kasvith kasvith commented Aug 25, 2018

Pull Request for issue #67

Description

  • Introduced RecoverableError interface
  • Marked token errors with this interface
  • Improved parser to handle these errors
  • When a type is not a RecoverableError or the error is not Recoverable the program will disconnect clients

Testing Instructions

  • Open kache with kache --debug
  • Open CLI with kache-cli
  • Exit CLI
  • Server should disconnect client

Additional Comments

@kasvith kasvith added bug Something isn't working level:intermediate issues that requires intermediate knowledge WIP issues that are currently WIP server issues related to kache-server labels Aug 25, 2018
@kasvith kasvith added this to the First Release milestone Aug 25, 2018
@kasvith kasvith self-assigned this Aug 25, 2018
@kasvith kasvith added this to In progress in Creating Basic Server via automation Aug 25, 2018
@kasvith kasvith merged commit 4aa48b8 into master Aug 25, 2018
Creating Basic Server automation moved this from In progress to Done Aug 25, 2018
@kasvith kasvith deleted the fix/recoverable-errors branch August 25, 2018 06:37
@kasvith kasvith mentioned this pull request Aug 25, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@kasvith kasvith

Labels
bug Something isn't working level:intermediate issues that requires intermediate knowledge server issues related to kache-server WIP issues that are currently WIP
Projects
Creating Basic Server
  
Done
Milestone
First Release
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kasvith