Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

Fix/thou shalt not defer #74

Merged
merged 3 commits into from
Aug 25, 2018
Merged

Fix/thou shalt not defer #74

merged 3 commits into from
Aug 25, 2018

Conversation

kasvith
Copy link
Owner

@kasvith kasvith commented Aug 25, 2018

Pull Request for issue #23

Description

Removed defer from

  • HMaps
  • Sets
  • Lists

Changed FLen of HMap to return number of bytes in the string

Testing Instructions

Run tests

Excepted Behavior

it should be passing

Actual Behavior

its passing

Additional Comments

@kasvith kasvith added bug Something isn't working server issues related to kache-server code style about code style labels Aug 25, 2018
@kasvith kasvith added this to the First Release milestone Aug 25, 2018
@kasvith kasvith self-assigned this Aug 25, 2018
@kasvith kasvith added this to In progress in Creating types via automation Aug 25, 2018
@kasvith kasvith mentioned this pull request Aug 25, 2018
@codecov
Copy link

codecov bot commented Aug 25, 2018

Codecov Report

Merging #74 into master will increase coverage by 1.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #74      +/-   ##
=========================================
+ Coverage   71.47%   72.5%   +1.02%     
=========================================
  Files          10      10              
  Lines         617     640      +23     
=========================================
+ Hits          441     464      +23     
  Misses        170     170              
  Partials        6       6
Impacted Files Coverage Δ
pkg/types/list/list.go 99.09% <100%> (+0.06%) ⬆️
pkg/types/hashmap/hmap.go 100% <100%> (ø) ⬆️
pkg/types/set/set.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d33d877...2fc084f. Read the comment docs.

@kasvith kasvith merged commit b2cdf4d into master Aug 25, 2018
Creating types automation moved this from In progress to Done Aug 25, 2018
@kasvith kasvith deleted the fix/thou-shalt-not-defer branch August 25, 2018 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working code style about code style server issues related to kache-server
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant