This repository has been archived by the owner on Apr 2, 2021. It is now read-only.
add resp3 protocol part 5(replace to resp3) #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chyroc
force-pushed
the
add-resp3-protocol-part-5
branch
from
96a2a39
to
c286dcb
Compare
kasvith
reviewed
Aug 27, 2018
| command, err := getCommand(cmd) | ||
| if err != nil { | ||
| return protcl.NewMessage(nil, err) | ||
| return &protcl.Resp3{Type: protcl.Resp3SimpleError, Str: err.Error()} |
There was a problem hiding this comment.
why not we add Err error to Resp3 to directly accept errors
There was a problem hiding this comment.
for now i will merge it we can replace it later
kasvith
added
enhancement
kasvith
approved these changes
Aug 27, 2018
|
tnx @chyroc |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for issue
#76
Description
replace protocol to resp3
Testing Instructions
Excepted Behavior
Actual Behavior
Additional Comments