-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT [Issue#3] add tools for static code analysis - Prettier init config old #9
Conversation
Is PR title correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KarolinaZakrzewska : Congrats on your first PR!!! 😸 🎉
As discussed on Discord, please install the prettier lib via npm package manager 🙏🏻
Well, it didn't say much about the changes, so I've just adjusted it as per our discussion on Discord - to keep the current convention going:
short description in present tense
Anyways, let's discuss the approach in more details in a upcoming meeting. Coz we might decide on something else instead. It's just how I do it for now, but my approach has been also evolving a bit since I started😅 |
now it's ok, thank you @bugITwhisperer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KarolinaZakrzewska please finish the changes - as I remember you're still working on it :)
closing due to conflicts with the latest version of main |
@KarolinaZakrzewska : are you planning to open a new PR with the Prettier config changes? :) |
Yes, I prepared a new PR #37 |
Partially Resolves #3
Scope of changes
How to use
Additionally, you can add the VSC extension: Prettier - Code formatter (you see it in extensions as recommended)
Right-click in the file e.g. package.json -> Format Document With... -> Configure Default Formatter... -> Select Prettier