Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

porting-check: no need for forward-port checks, since we only manage 2.x #40

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

egernst
Copy link
Member

@egernst egernst commented Feb 3, 2022

At this point, it doesn't make sense to check for forward-port labels.
This can be reverted at a later date if we are managing two branches
again.

Signed-off-by: Eric Ernst eric_ernst@apple.com

At this point, it doesn't make sense to check for forward-port labels.
This can be reverted at a later date if we are managing two branches
again.

Signed-off-by: Eric Ernst <eric_ernst@apple.com>
Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @egernst.

lgtm

@stale
Copy link

stale bot commented Mar 2, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. See [assisted pr workflow] (https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#assisted-pr-workflow) if any developers would like to help pickup this pull request. Thank you for your contributions.

@stale stale bot added the stale Issue or PR was not updated in a timely fashion label Mar 2, 2022
@jodh-intel
Copy link
Contributor

This has been open too long folks!

Ping @kata-containers/action-admins, @kata-containers/architecture-committee.

/cc @fidencio, @devimc.

Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @egernst!

@stale stale bot removed the stale Issue or PR was not updated in a timely fashion label Mar 7, 2022
@fidencio fidencio merged commit 8e47d4b into kata-containers:main Mar 7, 2022
jodh-intel added a commit to jodh-intel/.github that referenced this pull request Mar 11, 2022
Fix the syntax error introduce inadvertently on kata-containers#40 which is causing
GitHub Actions using this script to fail.

Fixes: kata-containers#43.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
likebreath pushed a commit that referenced this pull request Mar 11, 2022
Fix the syntax error introduce inadvertently on #40 which is causing
GitHub Actions using this script to fail.

Fixes: #43.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants