This repository has been archived by the owner on May 12, 2021. It is now read-only.
grpc: specify if shared pidns is needed in CreateSandbox #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laijs
reviewed
Nov 28, 2017
protocols/grpc/hyperstart.proto
Outdated
| @@ -103,6 +103,7 @@ message CreateSandboxRequest { | |||
| string hostname = 1; | |||
| repeated string dns = 2; | |||
| repeated Storage storages = 3; | |||
| bool shared_pidns = 4; | |||
There was a problem hiding this comment.
It seams that all the containers are forced to be shared the sandbox pidns.
I prefer create_sandbox_pidns or sandbox_pidns or infra_pidns.
Signed-off-by: Peng Tao <bergwolf@gmail.com>
bergwolf
force-pushed
the
shared_pidns
branch
from
9c13fd6
to
45ae9a6
Compare
|
LGTM, @sameo @sboeuf @jodh-intel WDYT? |
bergwolf
changed the title
|
LGTM |
|
hello, I'm trying to remove it and make it mandatory. #54 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use it to tell agent if a pod level pid namespace is required. We may want to just always use a pod level pidns but this option keeps in sync with k8s per-pod PID Namespace Sharing (kubernetes/enhancements#495) and crio
--disable-shared-pid-namespaceflag (cri-o/cri-o#1149).