This repository has been archived by the owner on May 12, 2021. It is now read-only.
agent: Fix the amount of bytes transmitted to the shim #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every time our GRPC functions ReadStdout() or ReadStderr() were called, the entire allocated buffer was returned. This is wrong since we don't know the amount of bytes we will get on both stdout and stderr. Instead, this patch returns the slice corresponding to the real amount of bytes read from the process. Fixes kata-containers#123 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
|
Relates to kata-containers/runtime#20 |
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
=======================================
Coverage 75.96% 75.96%
=======================================
Files 1 1
Lines 129 129
=======================================
Hits 98 98
Misses 16 16
Partials 15 15Continue to review full report at Codecov.
|
|
nice catch. |
|
LGTM |
|
+1 |
|
LGTM! |
|
Thanks for finding that @sboeuf :-) |
This was referenced Jan 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time our GRPC functions ReadStdout() or ReadStderr() were
called, the entire allocated buffer was returned. This is wrong
since we don't know the amount of bytes we will get on both stdout
and stderr. Instead, this patch returns the slice corresponding to
the real amount of bytes read from the process.
Fixes #123
Fixes kata-containers/runtime#20
Signed-off-by: Sebastien Boeuf sebastien.boeuf@intel.com