This repository has been archived by the owner on May 12, 2021. It is now read-only.
device: Do not allow container access to the nvdimm rootfs #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
devimc
reviewed
Jun 3, 2020
device.go
Outdated
| @@ -50,6 +50,7 @@ var ( | |||
| getPCIDeviceName = getPCIDeviceNameImpl | |||
| getDevicePCIAddress = getDevicePCIAddressImpl | |||
| scanSCSIBus = scanSCSIBusImpl | |||
| rootfsNvdimmDisk = "/dev/pmem0p1" | |||
There was a problem hiding this comment.
I think there is a different way to get the rootfs device
There was a problem hiding this comment.
@devimc PR updated. PTAL
Codecov Report
@@ Coverage Diff @@
## master #792 +/- ##
==========================================
+ Coverage 60.26% 60.45% +0.18%
==========================================
Files 17 17
Lines 2640 2655 +15
==========================================
+ Hits 1591 1605 +14
- Misses 890 891 +1
Partials 159 159 |
With this change, a container is not longer given access to the underlying nvdimm root partition. This is done by explicitly adding the nvdimm root partition to the device cgroup of the container. Fixes kata-containers#791 Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
amshinde
force-pushed
the
deny-nvdimm-devices-access
branch
from
75e275f
to
a88af32
Compare
|
/test |
jodh-intel
approved these changes
Jun 3, 2020
devimc
approved these changes
Jun 3, 2020
|
restarting ubuntu CI |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, a container is not longer given access to
the underlying nvdimm root partition.
This is done by explicitly adding the nvdimm root partition
to the device cgroup of the container.
Fixes #791
Signed-off-by: Archana Shinde archana.m.shinde@intel.com