Skip to content

Commit

Permalink
tests: Do not call install_check_metrics when installing kata
Browse files Browse the repository at this point in the history
The `install_kata` function was moved from the metrics' `gha-run.sh`
file to the `common.bash` in the commit 3ffd48b, but I didn't notice
that it brought with it a call to `install_check_metrics`, which is
totally unrelated to installing Kata Containers.

Let's remove the call so the function is a little bit less specific, and
move the call to install_check_metrics to the metrics `gha-run.sh` file.

Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
  • Loading branch information
fidencio committed Jul 21, 2023
1 parent e149a3c commit 13715db
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion tests/common.bash
Expand Up @@ -318,7 +318,6 @@ function install_kata() {

check_containerd_config_for_kata
restart_containerd_service
install_checkmetrics
}

function check_containerd_config_for_kata() {
Expand Down
2 changes: 1 addition & 1 deletion tests/metrics/gha-run.sh
Expand Up @@ -95,7 +95,7 @@ function run_test_tensorflow() {
function main() {
action="${1:-}"
case "${action}" in
install-kata) install_kata ;;
install-kata) install_kata && install_checkmetrics ;;
make-tarball-results) make_tarball_results ;;
run-test-launchtimes) run_test_launchtimes ;;
run-test-memory-usage) run_test_memory_usage ;;
Expand Down

0 comments on commit 13715db

Please sign in to comment.