Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

it's better to check whether the destination file existed in ensure_destination_exists #2247

Closed
lifupan opened this issue Jul 15, 2021 · 0 comments · Fixed by #2248
Closed

it's better to check whether the destination file existed in ensure_destination_exists #2247

lifupan opened this issue Jul 15, 2021 · 0 comments · Fixed by #2248
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
Issue backlog

Comments

@lifupan
Copy link
Member

lifupan commented Jul 15, 2021

it's better to check whether the destination file existed in ensure_destination_exists ,
if so, just return directly .
@lifupan lifupan added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Jul 15, 2021
lifupan pushed a commit to lifupan/kata-containers that referenced this issue Jul 15, 2021
mount: fix the issue of missing check file exists
5371b92 
It's better to check whether the destination file exists
before creating them, if it had been existed, then return
directly.

Fixes: kata-containers#2247

Signed-off-by: fupan.lfp <fupan.lfp@antgroup.com>
@lifupan lifupan mentioned this issue Jul 15, 2021
Merged
@katacontainersbot katacontainersbot moved this from To do to In progress in Issue backlog Jul 15, 2021
Issue backlog automation moved this from In progress to Done Jul 27, 2021
snir911 pushed a commit to snir911/kata-containers that referenced this issue Jul 29, 2021
@snir911
mount: fix the issue of missing check file exists
56d4408 
It's better to check whether the destination file exists
before creating them, if it had been existed, then return
directly.

Fixes: kata-containers#2247

Signed-off-by: fupan.lfp <fupan.lfp@antgroup.com>
@katacontainersbot katacontainersbot moved this from Done to In progress in Issue backlog Jul 29, 2021
snir911 pushed a commit to snir911/kata-containers that referenced this issue Aug 5, 2021
@snir911
mount: fix the issue of missing check file exists
5863106 
It's better to check whether the destination file exists
before creating them, if it had been existed, then return
directly.

Fixes: kata-containers#2247

Signed-off-by: fupan.lfp <fupan.lfp@antgroup.com>
snir911 pushed a commit to snir911/kata-containers that referenced this issue Aug 8, 2021
@snir911
mount: fix the issue of missing check file exists
78c204a 
It's better to check whether the destination file exists
before creating them, if it had been existed, then return
directly.

Fixes: kata-containers#2247

Signed-off-by: fupan.lfp <fupan.lfp@antgroup.com>
snir911 pushed a commit to snir911/kata-containers that referenced this issue Aug 8, 2021
@snir911
mount: fix the issue of missing check file exists
1b5fcdb 
It's better to check whether the destination file exists
before creating them, if it had been existed, then return
directly.

Fixes: kata-containers#2247

Signed-off-by: fupan.lfp <fupan.lfp@antgroup.com>
snir911 pushed a commit to snir911/kata-containers that referenced this issue Aug 8, 2021
@snir911
mount: fix the issue of missing check file exists
d9eea6b 
It's better to check whether the destination file exists
before creating them, if it had been existed, then return
directly.

Fixes: kata-containers#2247

Signed-off-by: fupan.lfp <fupan.lfp@antgroup.com>
snir911 pushed a commit to snir911/kata-containers that referenced this issue Aug 16, 2021
@snir911
mount: fix the issue of missing check file exists
44e3c71 
It's better to check whether the destination file exists
before creating them, if it had been existed, then return
directly.

Fixes: kata-containers#2247

Signed-off-by: fupan.lfp <fupan.lfp@antgroup.com>
snir911 pushed a commit to snir911/kata-containers that referenced this issue Aug 31, 2021
@snir911
mount: fix the issue of missing check file exists
ca50fc9 
It's better to check whether the destination file exists
before creating them, if it had been existed, then return
directly.

Fixes: kata-containers#2247

Signed-off-by: fupan.lfp <fupan.lfp@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
Issue backlog
  
In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mount: fix the issue of missing check file exists lifupan/kata-containers
1 participant
@lifupan