Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kata-ctl: Improve install rule #5403

Closed
jodh-intel opened this issue Oct 12, 2022 · 0 comments · Fixed by #6767
Closed

kata-ctl: Improve install rule #5403

jodh-intel opened this issue Oct 12, 2022 · 0 comments · Fixed by #6767
Assignees
@ngpatel6
Labels
kata-ctl Kata Control Tool project lang/rust Rust code needs-help Request for extra help (technical, resource, etc)
Projects
Issue backlog

Comments

@jodh-intel
Copy link
Contributor

Extend/change the install rule to allow the binary to be installed to a destination directory.

For inspiration, see:
@jodh-intel jodh-intel added needs-help Request for extra help (technical, resource, etc) lang/rust Rust code kata-ctl Kata Control Tool project labels Oct 12, 2022
@jodh-intel jodh-intel mentioned this issue Oct 12, 2022
Merged
@jodh-intel jodh-intel mentioned this issue Oct 26, 2022
Closed
@ngpatel6 ngpatel6 self-assigned this Apr 28, 2023
ngpatel6 added a commit to ngpatel6/kata-containers-hackathon-team2 that referenced this issue Apr 29, 2023
@ngpatel6
Update the kata-ctl install rule to allow it to be installed to a giv…
7c2988e 
…en directory

The Makefile was updated to use an INSTALL_PATH variable to track where the
kata-ctl binary should be installed.  If the user doesn't specify anything,
then it uses the default path that cargo uses.  Otherwise, it will install it
in the directory that the user specified.  The README.md file was also updated
to show how to use the new option.

This work was done by pair programming by the following contributors:
Cesar Tamayo
Kevin Mora Jimenez
Narendra Patel
Ray Karrenbauer
Srinath Duraisamy

Fixes kata-containers#5403

Signed-off-by: Narendra Patel <narendra.g.patel@intel.com>
@ngpatel6 ngpatel6 mentioned this issue Apr 29, 2023
Merged
@katacontainersbot katacontainersbot moved this from To do to In progress in Issue backlog Apr 29, 2023
ngpatel6 added a commit to ngpatel6/kata-containers-hackathon-team2 that referenced this issue May 15, 2023
@ngpatel6 @ctamayo92
@kjmoraji @rayk-intel @srinathduraisamy
kata-ctl: Allow INSTALL_PATH= to be specified
593840e 
Update the kata-ctl install rule to allow it to be installed to a given directory

The Makefile was updated to use an INSTALL_PATH variable to track where the
kata-ctl binary should be installed.  If the user doesn't specify anything,
then it uses the default path that cargo uses.  Otherwise, it will install it
in the directory that the user specified.  The README.md file was also updated
to show how to use the new option.

Fixes kata-containers#5403

Co-authored-by: Cesar Tamayo <cesar.tamayo@intel.com>
Co-authored-by: Kevin Mora Jimenez <kevin.mora.jimenez@intel.com>
Co-authored-by: Narendra Patel <narendra.g.patel@intel.com>
Co-authored-by: Ray Karrenbauer <ray.karrenbauer@intel.com>
Co-authored-by: Srinath Duraisamy <srinath.duraisamy@intel.com>
Signed-off-by: Narendra Patel <narendra.g.patel@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ngpatel6 ngpatel6

Labels
kata-ctl Kata Control Tool project lang/rust Rust code needs-help Request for extra help (technical, resource, etc)
Projects
Issue backlog
  
In progress
kata-ctl project
Status: Done
Milestone
No milestone
2 participants
@jodh-intel @ngpatel6