Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local build for nydus snapshotter missing #9094

Open
BbolroC opened this issue Feb 14, 2024 · 0 comments
Open

Local build for nydus snapshotter missing #9094

BbolroC opened this issue Feb 14, 2024 · 0 comments
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.
Projects
Issue backlog

Comments

@BbolroC
Copy link
Member

BbolroC commented Feb 14, 2024

Which feature do you think can be improved?

As #8953 and #8585 were merged, we could use the nydus snapshotter for confidential containers e2e test. But it turns out that a container image ghcr.io/containerd/nydus-snapshotter only supports x86_64. This image is required to deploy the snapshotter during the coco e2e test at:

kata-containers/.github/workflows/run-kata-coco-tests.yaml

Lines 60 to 62 in c95c37d

- name: Deploy Snapshotter
timeout-minutes: 5
run: bash tests/integration/kubernetes/gha-run.sh deploy-snapshotter

It would be great to build the image locally and make it available via a local registry for other platforms (e.g. internal nightly coco test for IBM SE https://github.com/kata-containers/kata-containers/actions/runs/7896678751/job/21551051487).
@BbolroC BbolroC added enhancement Improvement to an existing feature needs-review Needs to be assessed by the team. labels Feb 14, 2024
BbolroC added a commit to BbolroC/kata-containers that referenced this issue Feb 14, 2024
@BbolroC
CI|k8s: Skip vcpu allocation test for s390x
1a9c426 
A test `vcpu allocation k8s test` exhibits different behavior on s390x
For more details, please refer to issue kata-containers#9093.
This commit is to make the test skipped until the issue is resolved on
the platform.

Fixes: kata-containers#9094

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
@BbolroC BbolroC mentioned this issue Feb 14, 2024
Closed
@katacontainersbot katacontainersbot moved this from To do to In progress in Issue backlog Feb 14, 2024
BbolroC added a commit to BbolroC/kata-containers that referenced this issue Feb 24, 2024
@BbolroC
CI|k8s: Skip vcpu allocation test for s390x
88d369e 
A test `vcpu allocation k8s test` exhibits different behavior on s390x
For more details, please refer to issue kata-containers#9093.
This commit is to make the test skipped until the issue is resolved on
the platform.

Fixes: kata-containers#9094

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
BbolroC added a commit to BbolroC/kata-containers that referenced this issue Feb 29, 2024
@BbolroC
CI|k8s: Skip vcpu allocation test for s390x
6141b43 
A test `vcpu allocation k8s test` exhibits different behavior on s390x
For more details, please refer to issue kata-containers#9093.
This commit is to make the test skipped until the issue is resolved on
the platform.

Fixes: kata-containers#9094

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
BbolroC added a commit to BbolroC/kata-containers that referenced this issue Mar 14, 2024
@BbolroC
CI|k8s: Skip vcpu allocation test for s390x
2d44842 
A test `vcpu allocation k8s test` exhibits different behavior on s390x
For more details, please refer to issue kata-containers#9093.
This commit is to make the test skipped until the issue is resolved on
the platform.

Fixes: kata-containers#9094

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.
Projects
Issue backlog
  
In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP gha: Build nydus snapshotter image locally for unsupported platforms BbolroC/kata-containers
1 participant
@BbolroC