Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: fix the issue of crash agent without spec #125

Merged
merged 1 commit into from Jan 20, 2020

Conversation

lifupan
Copy link
Member

@lifupan lifupan commented Jan 18, 2020

To check is the oci spec passed in, other wise,
it would crash the agent unwrap it directly.

Fixes: #124

Signed-off-by: fupan.lfp fupan.lfp@antfin.com

To check is the oci spec passed in, other wise,
it would crash the agent unwrap it directly.

Fixes: kata-containers#124

Signed-off-by: fupan.lfp <fupan.lfp@antfin.com>
@yyyeerbo
Copy link
Contributor

/test

Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

lgtm

@jodh-intel jodh-intel merged commit b5e741b into kata-containers:master Jan 20, 2020
@lifupan lifupan deleted the fix_agent_crash branch January 20, 2020 13:00
dgibson pushed a commit to dgibson/kata-containers that referenced this pull request Aug 5, 2021
Enable Numa support for Power (ppc64le) architecture
sprt pushed a commit to sprt/kata-containers that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a mal create container request without oci spec would crash the agent
3 participants