cgroup: fix the issue of crashed when meet unsupported cgroup #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
bergwolf
approved these changes
Jul 15, 2020
|
Hi @jodh-intel Please take a look on this PR. |
jodh-intel
approved these changes
Jul 15, 2020
| "perf_event" => Some(Box::new(PerfEvent())), | ||
| "freezer" => Some(Box::new(Freezer())), | ||
| "name=systemd" => Some(Box::new(Named())), | ||
| _ => None, |
There was a problem hiding this comment.
Thanks @lifupan ! Might be worth adding a log call so we can see the agent detected an unusual cgroup:
info!(sl!(), "Found unexpected cgroup"; "cgroup" => name);
Fix the issue of applying/set to unsupported cgroups. Fixes: kata-containers#408 Signed-off-by: fupan.lfp <fupan.lfp@antfin.com>
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue of applying/set to unsupported cgroups.
Fixes: #408
Signed-off-by: fupan.lfp fupan.lfp@antfin.com