rustjail: fix the issue of invalid cgroup_parent path #694
Conversation
|
/test |
| @@ -1404,9 +1406,9 @@ impl Manager { | |||
| } | |||
|
|
|||
| let p = if value == "/" { | |||
| format!("{}{}", mnt.unwrap(), cpath) | |||
| format!("{}{}", mnt.unwrap(), cgroup_path) | |||
There was a problem hiding this comment.
Could you also change these unwrap()'s to map_err()?'s?
There was a problem hiding this comment.
Hi @jodh-intel
Those unwraps are on Option variables and they had been tested with is_some(), so here it's safe to unwrap on them.
There was a problem hiding this comment.
what happen if cpath doesn't start with '/' ?, cgroup_path will be empty, so p will be equal to mnt.unwrap(), is this expected ?
There was a problem hiding this comment.
Hi @devimc good point, I had updated.
There was a problem hiding this comment.
What about just using format!("{}/{}", xxx, xxx), adding an extra / in between in all cases?
There was a problem hiding this comment.
Yeah, that's an option, which let the kernel do the '/' deduplication.
|
/test |
The cgroup_parent path is expected to be absolute path, add an '/' prefix to the passed cgroup_parent path to make sure it's an absolute path. Fixes: kata-containers#336 Signed-off-by: fupan.lfp <fupan.lfp@antfin.com>
|
/test |
|
lgtm, I can confirm it fixed the issue for me #336 |
The cgroup_parent path is expected to be absolute path,
if it was passed a relative path, change it to be an
absolute path.
Fixes: #336
Signed-off-by: fupan.lfp fupan.lfp@antfin.com