Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: provide a guide for how to use IBM Secure Execution #7146

Merged
merged 1 commit into from Jan 23, 2024

Conversation

BbolroC
Copy link
Member

@BbolroC BbolroC commented Jun 20, 2023

This PR is to add a document for how to run kata containers under IBM Secure Execution environment.

Fixes: #7025

Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com

@BbolroC BbolroC requested a review from a team as a code owner June 20, 2023 11:44
@katacontainersbot katacontainersbot added the size/large Task of significant size label Jun 20, 2023
@stevenhorsman
Copy link
Member

Hey Choi this is failing with the error:
ERROR: Document docs/how-to/how-to-run-kata-containers-with-SE-VMs.md is not referenced, so I would suggest adding a link to the doc in docs/how-to/README.md

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought - I wonder if the CoCo operator section would be better off in the coco documentation. Maybe as a new entry in https://github.com/confidential-containers/documentation/tree/main/guides like sev has? It might be more appropriate to document/link to the kata-deploy in this doc?

@BbolroC
Copy link
Member Author

BbolroC commented Jun 20, 2023

Just a thought - I wonder if the CoCo operator section would be better off in the coco documentation. Maybe as a new entry in https://github.com/confidential-containers/documentation/tree/main/guides like sev has? It might be more appropriate to document/link to the kata-deploy in this doc?

Yeah, I will let you know after discussing what you mentioned with @hbrueckner . Thanks! 😉

@BbolroC
Copy link
Member Author

BbolroC commented Jun 21, 2023

@hbrueckner I have relocated the section for CC operator in confidential-containers/documentation#133 and made this document refer to the kata-deploy.

Copy link
Contributor

@hbrueckner hbrueckner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BbolroC ,

thanks for this excellent documentation. I have only a few edits and remarks to follow-up. Thanks a lot!

docs/how-to/how-to-run-kata-containers-with-SE-VMs.md Outdated Show resolved Hide resolved
docs/how-to/how-to-run-kata-containers-with-SE-VMs.md Outdated Show resolved Hide resolved
docs/how-to/how-to-run-kata-containers-with-SE-VMs.md Outdated Show resolved Hide resolved
docs/how-to/how-to-run-kata-containers-with-SE-VMs.md Outdated Show resolved Hide resolved
docs/how-to/how-to-run-kata-containers-with-SE-VMs.md Outdated Show resolved Hide resolved
docs/how-to/how-to-run-kata-containers-with-SE-VMs.md Outdated Show resolved Hide resolved
docs/how-to/how-to-run-kata-containers-with-SE-VMs.md Outdated Show resolved Hide resolved
docs/how-to/how-to-run-kata-containers-with-SE-VMs.md Outdated Show resolved Hide resolved
docs/how-to/how-to-run-kata-containers-with-SE-VMs.md Outdated Show resolved Hide resolved
@BbolroC BbolroC changed the title WIP docs: provide a guide for how to use IBM SE WIP docs: provide a guide for how to use IBM Secure Execution Jun 22, 2023
@katacontainersbot katacontainersbot added size/tiny Smallest and simplest task and removed size/large Task of significant size labels Jun 22, 2023
@katacontainersbot katacontainersbot added size/large Task of significant size and removed size/tiny Smallest and simplest task labels Jun 22, 2023
Copy link

@NicoBoehrIBM NicoBoehrIBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides one small nit, LGTM

Copy link
Contributor

@hbrueckner hbrueckner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just two minor edits

docs/how-to/how-to-run-kata-containers-with-SE-VMs.md Outdated Show resolved Hide resolved
docs/how-to/how-to-run-kata-containers-with-SE-VMs.md Outdated Show resolved Hide resolved
@BbolroC BbolroC force-pushed the ibm-se-howto-doc branch 5 times, most recently from 9943080 to 9ff825a Compare June 27, 2023 05:36
@BbolroC BbolroC changed the title WIP docs: provide a guide for how to use IBM Secure Execution docs: provide a guide for how to use IBM Secure Execution Oct 23, 2023
Copy link
Contributor

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BbolroC, this doc helped me to understand some decisions you took on #6755 so helped me on the review too!

@BbolroC
Copy link
Member Author

BbolroC commented Jan 22, 2024

For reviewers, you can find the referred documentation in the section Using Kata-Deploy with Confidential Containers Operator at confidential-containers/operator#329

metadata:
name: nginx-kata
spec:
runtimeClassName: kata-qemu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Choi, this is probably a stupid question, but where does kata-qemu-se runtimeClass come into use over kata-qemu. Is it just when using kata-deploy rather than the manual approach as the other runtime class hasn't been created?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The document starts with an assumption that kata container is installed. It would be good to have how to generate a new runtime class like kata-qemu-se to the doc, but I just wanted to make it focus on explaining how to run a kata container on IBM Z SE based on the basic setup.

And yes, you are right, a runtime class kata-qemu-se is introduced in the doc for confidential containers. 😉

@BbolroC
Copy link
Member Author

BbolroC commented Jan 22, 2024

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a spare z16 LPAR to test on, but I've read through the documentation and it looks good to me. Thanks!

If any of the results are not identifiable, please reach out to the responsible cloud
provider to enable the Secure Execution capability. Alternatively, if you possess
administrative privileges and the facility bit is set, you can enable the Secure Execution
capability by adding `prot_virt=1` to the kernel parameters and performing a system reboot with:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: ...performing a system reboot_, for example,_ with:....

The example is using the zipl.conf directly... there are meanwhile zipl support for BLS which need to be differently configured. So just make this as an example, as distros might vary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. The document has been updated.

resource `ccruntime` for confidential containers, enabling the operator to install Kata
binary artifacts such as kernel, shim-v2, and more.

In this section, we will specifically guide you on building a payload image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: remove "we" and use "you will learn" or "This section explains how" / "This section guides you through....."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. The document has been updated.

## Considerations for CI

If you intend to integrate the aforementioned procedure with a CI system, it is
recommended to configure the following setup for an environment variable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: remove "it is recommended" and simply use "configure"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. The document has been updated.

Copy link
Contributor

@hbrueckner hbrueckner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Choi,
thanks a lot for pulling this excellent guide together. I have only really minor remarks/edits that should not hold back any approval.

/approve

@BbolroC BbolroC force-pushed the ibm-se-howto-doc branch 2 times, most recently from 3c5e691 to 3d8c07e Compare January 23, 2024 17:38
This PR is to add a document for how to run kata containers under IBM
Secure Execution environment.

Fixes: kata-containers#7025

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
@BbolroC
Copy link
Member Author

BbolroC commented Jan 23, 2024

/test

@BbolroC BbolroC merged commit f429068 into kata-containers:main Jan 23, 2024
286 of 295 checks passed
@BbolroC BbolroC deleted the ibm-se-howto-doc branch January 23, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/large Task of significant size
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: provide a guide for how to use IBM SE with kata containers
7 participants