Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rootfs: build OPA binary from source for ppc64le and s390x #7769

Merged
merged 1 commit into from Dec 11, 2023

Conversation

BbolroC
Copy link
Member

@BbolroC BbolroC commented Aug 28, 2023

This PR is to build a binary for OPA from source code for ppc64le and s390x.

Fixes: #7616

Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com

@katacontainersbot katacontainersbot added the size/small Small and simple task label Aug 28, 2023
@BbolroC BbolroC added the do-not-merge PR has problems or depends on another label Aug 28, 2023
@BbolroC
Copy link
Member Author

BbolroC commented Aug 28, 2023

@danmihai1 Please check out a discussion for this PR: https://katacontainers.slack.com/archives/C879ACQ00/p1693216957300559

@katacontainersbot katacontainersbot added size/medium Average sized task and removed size/small Small and simple task labels Aug 28, 2023
@katacontainersbot katacontainersbot added size/small Small and simple task and removed size/medium Average sized task labels Aug 28, 2023
@zvonkok
Copy link
Contributor

zvonkok commented Aug 30, 2023

@BbolroC s/rootf/rootfs/ :)

@BbolroC BbolroC changed the title rootf: build OPA binary from source for ppc64le and s390x rootfs: build OPA binary from source for ppc64le and s390x Aug 30, 2023
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @BbolroC!

@fidencio fidencio added ok-to-test and removed do-not-merge PR has problems or depends on another labels Oct 11, 2023
@fidencio
Copy link
Member

/test

@fidencio
Copy link
Member

fidencio commented Nov 3, 2023

/test

Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BbolroC.

@jodh-intel jodh-intel added the safe-to-test Add to PR after manually reviewing to allow certain extra checks to run label Nov 7, 2023
@BbolroC
Copy link
Member Author

BbolroC commented Dec 8, 2023

/test

This PR is to build a binary for OPA from source code for ppc64le and s390x.

Fixes: kata-containers#7616

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
@BbolroC
Copy link
Member Author

BbolroC commented Dec 11, 2023

/test

@BbolroC BbolroC merged commit ea2a0dc into kata-containers:main Dec 11, 2023
171 of 174 checks passed
@BbolroC BbolroC deleted the opa-multiarch branch December 11, 2023 14:25
stevenhorsman added a commit to stevenhorsman/kata-containers that referenced this pull request Mar 26, 2024
Since kata-containers#7769, we support
building the OPA binary into the ppc64le and s390x arch versions of the rootfs,
so build the policy enabled agent to match for those architectures too.

Fixes: kata-containers#9355
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
zvonkok pushed a commit to zvonkok/kata-containers that referenced this pull request Apr 10, 2024
Since kata-containers#7769, we support
building the OPA binary into the ppc64le and s390x arch versions of the rootfs,
so build the policy enabled agent to match for those architectures too.

Fixes: kata-containers#9355
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
zvonkok pushed a commit to zvonkok/kata-containers that referenced this pull request Apr 16, 2024
Since kata-containers#7769, we support
building the OPA binary into the ppc64le and s390x arch versions of the rootfs,
so build the policy enabled agent to match for those architectures too.

Fixes: kata-containers#9355
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test safe-to-test Add to PR after manually reviewing to allow certain extra checks to run size/small Small and simple task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent Policy should be supported on s390x, powerpc64
6 participants