Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime-rs: Add Hybrid VSOCK device handling for CH #7815

Merged
merged 1 commit into from Nov 30, 2023
Merged

runtime-rs: Add Hybrid VSOCK device handling for CH #7815

merged 1 commit into from Nov 30, 2023

Conversation

cmaf
Copy link
Contributor

@cmaf cmaf commented Aug 31, 2023

Update cloud hypervisor implementation to allow hybrid vsock devices to be handled.

Fixes #6692

@cmaf cmaf added the wip Work in Progress (PR incomplete - needs more work or rework) label Aug 31, 2023
@cmaf cmaf requested a review from jodh-intel August 31, 2023 19:41
@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Aug 31, 2023
@cmaf cmaf changed the title runtime-rs: Add Hybrid VSOCK device handling runtime-rs: Add Hybrid VSOCK device handling for CH Aug 31, 2023
jodh-intel
jodh-intel approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cmaf.

lgtm

@jodh-intel
Copy link
Contributor

/test

@jodh-intel
Copy link
Contributor

/retest-arm

@cmaf
Copy link
Contributor Author

cmaf commented Sep 12, 2023

Hi @lifupan, how did you test adding a hybrid vsock device for dragonball?

@cmaf
Copy link
Contributor Author

cmaf commented Sep 22, 2023

Adding some of the contributors whose work touched vsock/hybrid vsock: @yipengyin @quanweiZhou, could you tell me how you tested adding a hybrid vsock device for dragonball?

@katacontainersbot katacontainersbot added size/medium Average sized task and removed size/tiny Smallest and simplest task labels Sep 27, 2023
@jodh-intel
Copy link
Contributor

/test

@cmaf cmaf removed the wip Work in Progress (PR incomplete - needs more work or rework) label Oct 25, 2023
@cmaf
Copy link
Contributor Author

cmaf commented Nov 21, 2023

/test

@cmaf cmaf added the safe-to-test Add to PR after manually reviewing to allow certain extra checks to run label Nov 22, 2023
@cmaf cmaf closed this Nov 22, 2023
@cmaf cmaf reopened this Nov 22, 2023
@cmaf
Copy link
Contributor Author

cmaf commented Nov 22, 2023

/test

@cmaf
runtime-rs: Add Hybrid VSOCK device handling for CH
98aa291 
Update cloud hypervisor implementation to allow hybrid vsock device to
be handled.

Fixes kata-containers#6692

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>
@cmaf
Copy link
Contributor Author

cmaf commented Nov 29, 2023

/test

@cmaf cmaf merged commit 207a7fe into kata-containers:main Nov 30, 2023
159 of 164 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amshinde amshinde amshinde approved these changes

@lifupan lifupan lifupan approved these changes

@jodh-intel jodh-intel jodh-intel approved these changes

Assignees
No one assigned
Labels
ok-to-test runtime-rs safe-to-test Add to PR after manually reviewing to allow certain extra checks to run size/medium Average sized task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runtime-rs: cs: Implement VSOCK / Hybrid VSOCK device handling
6 participants
@cmaf @jodh-intel @amshinde @lifupan @studychao @katacontainersbot