Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Re-add tracing tests and move docker/nerdctl to the basic-ci-amd64.yaml file #8174

Merged
merged 3 commits into from Nov 13, 2023

Conversation

fidencio
Copy link
Member

@fidencio fidencio commented Oct 9, 2023

We're just bringing back the tracing tests after the breakage was solved, and also taking the advantage to move the docker / nerdctl tests to the basic-ci-amd64.yaml file.

@katacontainersbot katacontainersbot added the size/huge Largest and most complex task (probably needs breaking into small pieces) label Oct 9, 2023
@fidencio fidencio added force-skip-ci Stop the CI running for a PR (remember: if you break it, you fix it!) ok-to-test labels Oct 9, 2023
Copy link
Member

@bergwolf bergwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Peng Tao made this move as part of 1280f85, and here we're
simply adjusting to the move.

Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
There's no need to keep those as separate files, and by having those in
the basic-ci-amd64.yaml file actually helps us to avoid the
undocummented GHA limitation about the number of files imported.

Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
@fidencio
Copy link
Member Author

/test

Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fidencio!

lgtm

@fidencio fidencio merged commit c858ea1 into kata-containers:main Nov 13, 2023
138 of 142 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force-skip-ci Stop the CI running for a PR (remember: if you break it, you fix it!) ok-to-test size/huge Largest and most complex task (probably needs breaking into small pieces)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants