Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kata-deploy: fix deprecations on kustomization files #8269

Merged
merged 1 commit into from Jan 31, 2024

Conversation

wainersm
Copy link
Contributor

By running kustomize edit fix on those files they have changed deprecated instructions ('bases' and 'patchesStrategicMerge') as well as 'apiVersion' and 'kind' were added.

Fixes #8268
Signed-off-by: Wainer dos Santos Moschetta wainersm@redhat.com

@wainersm wainersm added the area/kata-deploy Impacts the kata-deploy script label Oct 20, 2023
@katacontainersbot katacontainersbot added the size/medium Average sized task label Oct 20, 2023
@fidencio
Copy link
Member

/test

Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @wainersm!

@wainersm
Copy link
Contributor Author

wainersm commented Nov 1, 2023

I only rebased to main and pushed again to pick the fix for checking the code on bare-metal machines (where sometimes a git rebase is left halfway).

@wainersm
Copy link
Contributor Author

wainersm commented Nov 1, 2023

/test

By running `kustomize edit fix` on those files they have changed
deprecated instructions ('bases' and 'patchesStrategicMerge') as well as
'apiVersion' and 'kind' were added.

Fixes kata-containers#8268
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
@wainersm
Copy link
Contributor Author

Rebased the PR. let's see if CI passes.

@wainersm
Copy link
Contributor Author

/test

@fidencio fidencio merged commit 39a64d1 into kata-containers:main Jan 31, 2024
282 of 292 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kata-deploy Impacts the kata-deploy script ok-to-test size/medium Average sized task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kata-deploy: fix deprecations on kustomization files
4 participants