runtime-rs: Enhancing DirectVolMount Handling with Patching Support #8301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apokleos
force-pushed
the
do-direct-volume
branch
2 times, most recently
from
e5ed9f6
to
3c97361
Compare
Tim-Zhang
reviewed
Oct 26, 2023
Apokleos
force-pushed
the
do-direct-volume
branch
2 times, most recently
from
8262827
to
b230792
Compare
lifupan
reviewed
Oct 26, 2023
Apokleos
force-pushed
the
do-direct-volume
branch
from
b230792
to
791f2d9
Compare
quanweiZhou
reviewed
Oct 30, 2023
Apokleos
force-pushed
the
do-direct-volume
branch
from
791f2d9
to
df82333
Compare
katacontainersbot
added
size/large
Apokleos
force-pushed
the
do-direct-volume
branch
from
df82333
to
0c408ba
Compare
quanweiZhou
reviewed
Nov 15, 2023
Apokleos
force-pushed
the
do-direct-volume
branch
2 times, most recently
from
3af9ff8
to
9e8b978
Compare
Apokleos
force-pushed
the
do-direct-volume
branch
from
9e8b978
to
dd62c73
Compare
|
/test |
quanweiZhou
reviewed
Nov 24, 2023
src/runtime-rs/crates/resource/src/volume/direct_block_volume.rs
Outdated
Show resolved
Hide resolved
src/runtime-rs/crates/resource/src/volume/direct_block_volume.rs
Outdated
Show resolved
Hide resolved
src/runtime-rs/crates/resource/src/volume/direct_block_volume.rs
Outdated
Show resolved
Hide resolved
(1) rawblock volume is directvol mount type. (2) block volume is based on the bind mount type. Fixes: kata-containers#8300 Signed-off-by: alex.lyn <alex.lyn@antgroup.com>
Fixes: kata-containers#8300 Signed-off-by: alex.lyn <alex.lyn@antgroup.com>
Add a new dire direct_volumes containing spdk, rawblock and vfio volume. Fixes: kata-containers#8300 Signed-off-by: alex.lyn <alex.lyn@antgroup.com>
Fiexes: kata-containers#8300 Signed-off-by: alex.lyn <alex.lyn@antgroup.com>
Apokleos
force-pushed
the
do-direct-volume
branch
from
dd62c73
to
9eef30b
Compare
katacontainersbot
added
size/huge
|
/test |
quanweiZhou
approved these changes
Nov 27, 2023
Tim-Zhang
approved these changes
Nov 27, 2023
Fiexes: kata-containers#8300 Signed-off-by: alex.lyn <alex.lyn@antgroup.com>
The current infra(K8S, CSI, CRI, Containerd) for Kata containers is unable to properly handle direct volumes, resulting in the need for workarounds like searching/comparision and then patch up volume type. In this commit, reimplement of handling method is added to support raw block volume which backends may be rawdisk or other format file. Fixes: kata-containers#8300 Signed-off-by: alex.lyn <alex.lyn@antgroup.com>
(1) Add enum DirectVolumeType for direct volumes. (2) Reimplement spdk volume into direct_volume and do alignment of rawblock volume. Fixes: kata-containers#8300 Signed-off-by: alex.lyn <alex.lyn@antgroup.com>
Reimplement vfio volume into direct_volume and do alignment of rawblock/spdk volume. Fixes: kata-containers#8300 Signed-off-by: alex.lyn <alex.lyn@antgroup.com>
Apokleos
force-pushed
the
do-direct-volume
branch
from
9eef30b
to
fe68f25
Compare
|
/test-ubuntu |
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current infra(K8S, CSI, CRI, Containerd) for Kata containers is unable to properly handle direct volumes, resulting in the need for workarounds like patching up mount type and options after it created.
Fixes: #8300