New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release process documentation #8309
Update release process documentation #8309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Just one comment.
With this I think we can now update the readme for the tests repo mentioning that it is no longer used and archive the repo as well. |
3eecbf9
to
d43c7b1
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @gkurz!
Let's wait for #8308 to be merged first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gkurz - A few suggestions...
This is already tested by CI for every PR. Drop this step from the release process documentation. Fixes kata-containers#8302 Signed-off-by: Greg Kurz <groug@kaod.org>
The hub tool is deprecated. Releases are now based on the official gh CLI. A notable improvement : when properly setup (see [1]), gh allows to directly use HTTPS with one's GitHub credentials, instead of having to setup proper SSH access for pushes to the repo. Adjust the documentation accordingly. Fixes kata-containers#8302 [1] https://docs.github.com/en/github-cli/github-cli/quickstart#prerequisites Signed-off-by: Greg Kurz <groug@kaod.org>
Now that most of the test repository got migrated to the main Kata repository, it is no longer needed to tag the test repository when doing a release. Update the documentation accordingly by dropping all references to the test repository and only mention *the* Kata repository. Fixes kata-containers#8302 Signed-off-by: Greg Kurz <groug@kaod.org>
d43c7b1
to
b27b4ce
Compare
Hi @jodh-intel ! I've processed your suggestions. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gkurz.
/test |
It's true that the test repo isn't supposed to receive any new change but it is still used for the |
Reflect latest changes in the documentation :
Fixes #8302