Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release process documentation #8309

Merged
merged 3 commits into from Nov 10, 2023

Conversation

gkurz
Copy link
Member

@gkurz gkurz commented Oct 24, 2023

Reflect latest changes in the documentation :

  • No longer run kata-deploy test when releasing
  • Release now uses the official GitHub CLI
  • No longer release the test repository

Fixes #8302

Copy link
Member

@amshinde amshinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Just one comment.

docs/Release-Process.md Outdated Show resolved Hide resolved
@amshinde
Copy link
Member

With this I think we can now update the readme for the tests repo mentioning that it is no longer used and archive the repo as well.

@gkurz gkurz force-pushed the update-release-process-doc branch 2 times, most recently from 3eecbf9 to d43c7b1 Compare October 30, 2023 09:10
@gkurz gkurz marked this pull request as ready for review October 30, 2023 14:08
@gkurz gkurz requested a review from a team as a code owner October 30, 2023 14:08
@amshinde
Copy link
Member

/test

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @gkurz!

@gkurz gkurz added the do-not-merge PR has problems or depends on another label Oct 31, 2023
@gkurz
Copy link
Member Author

gkurz commented Oct 31, 2023

Let's wait for #8308 to be merged first.

@gkurz gkurz added no-backport-needed and removed do-not-merge PR has problems or depends on another labels Nov 2, 2023
Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gkurz - A few suggestions...

docs/Release-Process.md Outdated Show resolved Hide resolved
docs/Release-Process.md Outdated Show resolved Hide resolved
docs/Release-Process.md Outdated Show resolved Hide resolved
docs/Release-Process.md Outdated Show resolved Hide resolved
This is already tested by CI for every PR. Drop this step from the release
process documentation.

Fixes kata-containers#8302

Signed-off-by: Greg Kurz <groug@kaod.org>
The hub tool is deprecated. Releases are now based on the official gh
CLI. A notable improvement : when properly setup (see [1]), gh allows
to directly use HTTPS with one's GitHub credentials, instead of having
to setup proper SSH access for pushes to the repo.

Adjust the documentation accordingly.

Fixes kata-containers#8302

[1] https://docs.github.com/en/github-cli/github-cli/quickstart#prerequisites

Signed-off-by: Greg Kurz <groug@kaod.org>
Now that most of the test repository got migrated to the main Kata repository,
it is no longer needed to tag the test repository when doing a release.

Update the documentation accordingly by dropping all references to the test
repository and only mention *the* Kata repository.

Fixes kata-containers#8302

Signed-off-by: Greg Kurz <groug@kaod.org>
@gkurz
Copy link
Member Author

gkurz commented Nov 7, 2023

Hi @jodh-intel ! I've processed your suggestions. PTAL.

Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gkurz.

@amshinde
Copy link
Member

amshinde commented Nov 9, 2023

/test

@gkurz
Copy link
Member Author

gkurz commented Nov 9, 2023

With this I think we can now update the readme for the tests repo mentioning that it is no longer used and archive the repo as well.

It's true that the test repo isn't supposed to receive any new change but it is still used for the make static-checks in the CI AFAICT. I think we should only archive it when we are fully done with it to avoid confusion.

@stevenhorsman stevenhorsman merged commit b23952c into kata-containers:main Nov 10, 2023
56 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: Release process update
4 participants