Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agent: use method params instead of const params in functions #8326

Merged
merged 1 commit into from Jan 9, 2024
Merged

agent: use method params instead of const params in functions #8326

merged 1 commit into from Jan 9, 2024

Conversation

cheriL
Copy link
Contributor

@cheriL cheriL commented Oct 27, 2023

Fixes: #8325

@katacontainersbot
Copy link
Contributor

Can one of the admins verify this patch?

gkurz
gkurz approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @cheriL !

@gkurz
Copy link
Member

gkurz commented Dec 11, 2023

LGTM. Thanks @cheriL !

@cheriL Note that there were some changes in CI that require you to rebase this PR and force-push.

@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Dec 25, 2023
@cheriL
Copy link
Contributor Author

cheriL commented Dec 25, 2023

@gkurz Done

@cheriL @gkurz
agent: use method params instead of const params in functions
7c176a6 
Fixes: kata-containers#8325

Signed-off-by: soup <lqh348659137@outlook.com>
@gkurz
Copy link
Member

gkurz commented Jan 4, 2024

I've rebased again to get some more CI fixes.

@gkurz
Copy link
Member

gkurz commented Jan 8, 2024

/test

@gkurz gkurz merged commit e3611cf into kata-containers:main Jan 9, 2024
167 of 175 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkurz gkurz gkurz approved these changes

@amshinde amshinde amshinde approved these changes

Assignees
No one assigned
Labels
ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use method params instead of const params in functions
4 participants
@cheriL @katacontainersbot @gkurz @amshinde