runitme-rs/bugfix: kata pod with multi-containers sharing one direct volume #8332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apokleos
requested review from
lifupan,
studychao,
quanweiZhou and
Tim-0731-Hzt
Apokleos
force-pushed
the
bugfix-directvol-multicontainers
branch
from
267f500
to
15d8da1
Compare
Apokleos
changed the title
Apokleos
force-pushed
the
bugfix-directvol-multicontainers
branch
from
15d8da1
to
d7dbb15
Compare
quanweiZhou
approved these changes
Oct 30, 2023
Tim-0731-Hzt
approved these changes
Nov 2, 2023
amshinde
approved these changes
Nov 8, 2023
|
/test |
When a direct volume is used by multiple containers in Kata, Generating many shared paths with cids will cause IO error as the result of one direct volume mounts more than once. To correct it, use the device_id instead of cid which ensures that the guest only mounts the FS once. Fixes: kata-containers#8328 Signed-off-by: alex.lyn <alex.lyn@antgroup.com>
When multiple containers in a kata pod share one direct volume, it's important to make sure that the corresponding block device is only mounted once in the guest. This means that there should be only one mount entry for the device in the mount information. Fixes: kata-containers#8328 Signed-off-by: alex.lyn <alex.lyn@antgroup.com>
Apokleos
force-pushed
the
bugfix-directvol-multicontainers
branch
from
d7dbb15
to
ba632ba
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple containers in a kata pod share one direct volume, it's important to make sure that the corresponding block device is only mounted once in the guest. This means that there should be only one mount entry for the device in the mount information.
Fixes: #8328