kata-manager: Add support for Docker CLI installation #8376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodh-intel
reviewed
Nov 3, 2023
fidencio
force-pushed
the
topic/kata-manager-add-support-for-docker-installation
branch
2 times, most recently
from
156d817
to
ed62d66
Compare
jodh-intel
reviewed
Nov 6, 2023
jodh-intel
reviewed
Nov 6, 2023
jodh-intel
reviewed
Nov 6, 2023
jodh-intel
reviewed
Nov 6, 2023
jodh-intel
reviewed
Nov 6, 2023
fidencio
force-pushed
the
topic/kata-manager-add-support-for-docker-installation
branch
from
86a7676
to
c2cc918
Compare
katacontainersbot
added
size/large
|
@jodh-intel, addressed all the comments, and have successfully tested it locally. |
|
/test |
|
/retest-arm-unit |
jodh-intel
reviewed
Nov 8, 2023
Right now we're only testing with `ctr` and there's no change in behaviour with this commit. However, allowing to pass a tool to run the tests with gives us an easier time when expanding kata-manager to support, for instance, docker and nerdctl. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
fidencio
force-pushed
the
topic/kata-manager-add-support-for-docker-installation
branch
from
37fca1f
to
67e9685
Compare
|
@jodh-intel, this is, yet again, ready for your review. |
jodh-intel
approved these changes
Nov 9, 2023
Add support for also installing the Docker CLI, giving users the chance to try Kata Containers with docker in the same way we provide users the chance to try Kata Containers with `ctr`. Fixes: kata-containers#8357 Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
As "/etc/containerd/config.toml" is used from more than one place, let's just make it a global var. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
fidencio
force-pushed
the
topic/kata-manager-add-support-for-docker-installation
branch
from
1b03052
to
5d10aed
Compare
|
/test |
cmaf
approved these changes
Nov 10, 2023
amshinde
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for also installing the Docker CLI, giving users the chance
to try Kata Containers with docker in the same way we provide users the
chance to try Kata Containers with
ctr.Fixes: #8357