runtime-rs on arm64: Fixes unable to Boot Container Image using Cloud… #8422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
katacontainersbot
added
size/small
brianwang12
force-pushed
the
runtime-rs-arm64-with-CLH
branch
from
b20c44d
to
c9d07af
Compare
|
Hi @brianwang12 -, please remove the "changeId" line in your commit message. |
brianwang12
force-pushed
the
runtime-rs-arm64-with-CLH
branch
from
c9d07af
to
6bad5cd
Compare
katacontainersbot
added
size/tiny
brianwang12
force-pushed
the
runtime-rs-arm64-with-CLH
branch
from
6bad5cd
to
07f69b7
Compare
Done |
jodh-intel
approved these changes
Nov 14, 2023
Comment on lines
146
to
147
|
|
||
|
|
There was a problem hiding this comment.
Nit: Extra blank line not required.
| #[cfg(target_arch = "aarch64")] | ||
| let console_param_debug = KernelParams::from_string("console=ttyAMA0,115200n8"); | ||
|
|
||
|
|
||
| let mut rootfs_param = KernelParams::new_rootfs_kernel_params(rootfs_driver, rootfs_type)?; | ||
|
|
||
| let mut console_params = if enable_debug { | ||
| if confidential_guest { |
There was a problem hiding this comment.
Not related to this PR, but would you be able to look at raising a PR to allow confidential_guest=true on aarch64 with runtime-rs and CH?
There was a problem hiding this comment.
There is no confidential computing support in any of VMM on aarch64 for now. So, I think it's not the time to enable confidential guest.
jodh-intel
added
safe-to-test
|
/test |
brianwang12
force-pushed
the
runtime-rs-arm64-with-CLH
branch
from
07f69b7
to
9cfbfc1
Compare
|
/test |
In the case of Cloud Hypervisor running on arm64 architecture, only arm AMBA UART (pl011) is supported as the TTY. Consequently, when enabling Hypervisor debug mode, it's essential to configure the console as "ttyAMA0" rather than "ttyS0 Fixes: kata-containers#8381 Signed-off-by: briwan01 <brian.wang@arm.com>
brianwang12
force-pushed
the
runtime-rs-arm64-with-CLH
branch
from
9cfbfc1
to
20f75d9
Compare
|
/test |
amshinde
approved these changes
Nov 17, 2023
|
/test-arm |
|
Thanks @brianwang12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses the issue of being unable to boot container images using Cloud-Hypervisor on arm64
Fitxes: #8381