osbuilder: add pkg bash for alpine #8456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
fidencio
approved these changes
Nov 16, 2023
|
I've approved this, but you'll need to re-work the PR to properly add a commit message explaining why we're adding the Please, do that and our CI will then be happy. |
cmaf
reviewed
Nov 16, 2023
There was a problem hiding this comment.
@cheriL could you also make sure the Fixes line is in the commit (following the contributing guide)
cheriL
force-pushed
the
8447/alpine_bash
branch
from
74dc264
to
e06578f
Compare
amshinde
approved these changes
Nov 20, 2023
|
/test |
|
@cheriL, can we have this one rebased again? Sorry, for inconvenience. |
The bash component is required in the guest for debug console to work properly. Fixes: kata-containers#8447 Signed-off-by: soup <lqh348659137@outlook.com>
cheriL
force-pushed
the
8447/alpine_bash
branch
from
e06578f
to
811ec07
Compare
|
@fidencio Done |
|
/test |
|
/retest-dragonball |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #8447