Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dragonball: init dbs-pci lib with pci bus & pci conf #8480

Merged
merged 1 commit into from Dec 4, 2023

Conversation

studychao
Copy link
Member

This commit inits dbs-pci lib for Dragonball to use. It contains several implementation now:

  1. PCI configuration space
  2. PCI bus

More info of the design & behavior of those two features could be found in the README of dbs-cli.

fixes: #8479

@studychao studychao requested a review from a team as a code owner November 21, 2023 06:34
@katacontainersbot katacontainersbot added the size/huge Largest and most complex task (probably needs breaking into small pieces) label Nov 21, 2023
@ZizhengBian
Copy link
Contributor

Should we add other author's sob in commit log?

@studychao studychao force-pushed the chao/add_dbs_pci branch 2 times, most recently from c0d17dc to 2b0c24e Compare November 21, 2023 09:34
@studychao
Copy link
Member Author

Should we add other author's sob in commit log?

updated~

src/dragonball/src/dbs_pci/Cargo.toml Outdated Show resolved Hide resolved
src/dragonball/src/dbs_pci/src/bus.rs Show resolved Hide resolved
src/dragonball/src/dbs_pci/src/configuration.rs Outdated Show resolved Hide resolved
src/dragonball/src/dbs_pci/src/device.rs Show resolved Hide resolved
src/dragonball/src/dbs_pci/src/device.rs Outdated Show resolved Hide resolved
src/dragonball/src/dbs_pci/src/lib.rs Show resolved Hide resolved
src/dragonball/src/dbs_pci/src/lib.rs Show resolved Hide resolved
src/dragonball/src/dbs_pci/src/lib.rs Show resolved Hide resolved
@studychao studychao force-pushed the chao/add_dbs_pci branch 3 times, most recently from 00a7812 to a8bc6da Compare November 23, 2023 12:04
@justxuewei
Copy link
Member

Is commit message right?

More info of the design & behavior of those two features could be found
in the README of dbs-cli.

dbs-cli -> dbs_pci?

@studychao
Copy link
Member Author

Is commit message right?

More info of the design & behavior of those two features could be found
in the README of dbs-cli.

dbs-cli -> dbs_pci?

omg, nice catch

Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks @studychao! A few comments here.

src/dragonball/src/dbs_pci/src/bus.rs Outdated Show resolved Hide resolved
src/dragonball/src/dbs_pci/src/bus.rs Outdated Show resolved Hide resolved
src/dragonball/src/dbs_pci/src/bus.rs Outdated Show resolved Hide resolved
@studychao studychao force-pushed the chao/add_dbs_pci branch 2 times, most recently from 408fba2 to 4e49922 Compare November 30, 2023 12:28
This commit inits dbs-pci lib for Dragonball to use.
It contains several implementation now:

1. PCI configuration space
2. PCI bus

More info of the design & behavior of those two features could be found
in the README of dbs-pci.

fixes: kata-containers#8479

Signed-off-by: Gerry Liu <gerry@linux.alibaba.com>
Signed-off-by: Zizheng Bian <zizheng.bian@linux.alibaba.com>
Signed-off-by: Shifang Feng <fengshifang@linux.alibaba.com>
Signed-off-by: Yang Su <yang.su@linux.alibaba.com>
Signed-off-by: Zha Bin <zhabin@linux.alibaba.com>
Signed-off-by: Xin Lin <jingshan@linux.alibaba.com>
Signed-off-by: Chao Wu <chaowu@linux.alibaba.com>
@studychao
Copy link
Member Author

/test

1 similar comment
@studychao
Copy link
Member Author

/test

@studychao studychao merged commit 1550ee6 into kata-containers:main Dec 4, 2023
161 of 166 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test runtime-rs size/huge Largest and most complex task (probably needs breaking into small pieces)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dragonball: add pci bus & pci configuration space implementation
5 participants