runtime: Pass KataVirtualVolume to the guest as devices in go runtime
#8494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengyuZhu6
changed the title
KataVirtualVolumeKataVirtualVolume in go runtime
ChengyuZhu6
force-pushed
the
kata_virtual_volume
branch
from
d6284a3
to
4825e99
Compare
ChengyuZhu6
added
the
area/runtime
ChengyuZhu6
force-pushed
the
kata_virtual_volume
branch
2 times, most recently
from
aabdaff
to
2eddaad
Compare
ChengyuZhu6
requested review from
fidencio,
jiangliu,
wedsonaf,
bpradipt and
stevenhorsman
ChengyuZhu6
force-pushed
the
kata_virtual_volume
branch
from
2eddaad
to
4727c9d
Compare
ChengyuZhu6
changed the title
KataVirtualVolume in go runtimeKataVirtualVolume to the guest by devices in go runtime
ChengyuZhu6
changed the title
KataVirtualVolume to the guest by devices in go runtimeKataVirtualVolume to the guest as devices in go runtime
ChengyuZhu6
added
merge-to-main
This was referenced Nov 23, 2023
|
/test |
Comment on lines
525
to
509
| ///TODO implement the logic with KataVirtualVolume types | ||
| switch volumeType { | ||
| case types.KataVirtualVolumeImageGuestPullType: | ||
| case types.KataVirtualVolumeImageRawBlockType, types.KataVirtualVolumeLayerRawBlockType: | ||
| case types.KataVirtualVolumeImageNydusBlockType, types.KataVirtualVolumeLayerNydusBlockType: | ||
| case types.KataVirtualVolumeImageNydusFsType, types.KataVirtualVolumeLayerNydusFsType: | ||
| case types.KataVirtualVolumeDirectBlockType: | ||
| default: | ||
| } |
There was a problem hiding this comment.
Hey Chengyu, you have a couple of these volumeType switch blocks with TODOs, which I'm wondering about.
They don't seem to be doing anything at the moment, so are they set-up for a future PR? Would it be worth saving these blocks to that PR rather than adding code that doesn't do anything right now? Thanks!
The snapshotter will place `KataVirtualVolume` information into 'rootfs.options' and commence with the prefix 'io.katacontainers.volume='. The purpose of this commit is to transform the encapsulated KataVirtualVolume data into device information. Fixes: kata-containers#8495 Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com> Co-authored-by: Feng Wang <feng.wang@databricks.com> Co-authored-by: Samuel Ortiz <sameo@linux.intel.com> Co-authored-by: Wedson Almeida Filho <walmeida@microsoft.com>
To enhance the construction and administration of `Katavirtualvolume` storages, this commit expands the 'sharedFile' structure to manage both rootfs storages(`containerStorages`) including `Katavirtualvolume` and other data volumes storages(`volumeStorages`). NOTE: `volumeStorages` is intended for future extensions to support Kubernetes data volumes. Currently, `KataVirtualVolume` is exclusively employed for container rootfs, hence only `containerStorages` is actively utilized. Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
1) Extract function `handleBlockVolume` to create Storage only. 2) Add functions to handle KataVirtualVolume device and construct corresponding storages. Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6
force-pushed
the
kata_virtual_volume
branch
3 times, most recently
from
8efbb60
to
817cea2
Compare
1) Creating storage for all `io.katacontainers.volume=` messages in rootFs.Options, and then aggregates all storages into `containerStorages`. 2) Creating storage for other data volumes and push them into `volumeStorages`. Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6
force-pushed
the
kata_virtual_volume
branch
from
817cea2
to
5318afe
Compare
stevenhorsman
approved these changes
Nov 23, 2023
|
/test |
|
It would be great to sync these changes to runtime-rs too, @studychao |
jiangliu
approved these changes
Nov 24, 2023
|
/test |
studychao
added
the
port-to-runtime-rs
label added. |
hsiangkao
approved these changes
Nov 24, 2023
|
/test |
ChengyuZhu6
changed the title
KataVirtualVolume to the guest as devices in go runtimeKataVirtualVolume to the guest as devices in go runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass
KataVirtualVolumeto the guest as devices(#7698, #8471) to support nydus image, raw block image, direct volume and image pulling on the guest.This will be a core dependency for several other PRs(#8484, #7837).
Notes: This code is the outcome of extracting the logic about
KataVirtualVolumefrom two PRs(#7688, #7676) in CCv0 that have been merged.Fixes: #8495