Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deployment: Add stable overlay for kata-deploy.yaml #8509

Merged
merged 1 commit into from Dec 7, 2023
Merged

deployment: Add stable overlay for kata-deploy.yaml #8509

merged 1 commit into from Dec 7, 2023

Conversation

zvonkok
Copy link
Contributor

@zvonkok zvonkok commented Nov 23, 2023

Fixes: #8508

@katacontainersbot katacontainersbot added the size/small Small and simple task label Nov 23, 2023
@zvonkok zvonkok force-pushed the stable-overlay branch 3 times, most recently from 6ca24d9 to 5d8f6a7 Compare November 23, 2023 15:28
@zvonkok zvonkok force-pushed the stable-overlay branch 5 times, most recently from 9a4ebad to 209bbd6 Compare November 23, 2023 18:45
@katacontainersbot katacontainersbot added size/tiny Smallest and simplest task and removed size/small Small and simple task labels Nov 23, 2023
@katacontainersbot katacontainersbot added size/small Small and simple task and removed size/tiny Smallest and simplest task labels Nov 23, 2023
@zvonkok
Copy link
Contributor Author

zvonkok commented Nov 24, 2023

/ok-to-test

@zvonkok
Copy link
Contributor Author

zvonkok commented Nov 24, 2023

/test

fidencio
fidencio approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @zvonkok!

@fidencio
Copy link
Member

fidencio commented Dec 6, 2023

/test-power

gkurz
gkurz reviewed Dec 6, 2023
View reviewed changes
Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea looks great @zvonkok. What are the plans to fully get rid of kata-deploy-stable.yaml, which is still mentioned in the documentation and used by the release script ?

@zvonkok
deployment: Create a stable overaly for kata-deploy
1638055 
Fixes: kata-containers#8508

Create a stable overlay for kata-deploy.yaml so we do not have to maintain two files, only one.
Single source for both. This is also preparation for the helm-overlay

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
@zvonkok
Copy link
Contributor Author

zvonkok commented Dec 6, 2023

/test

gkurz
gkurz approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @zvonkok !

@gkurz gkurz merged commit 501910d into kata-containers:main Dec 7, 2023
165 of 175 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fidencio fidencio fidencio approved these changes

@gkurz gkurz gkurz approved these changes

Assignees
No one assigned
Labels
ok-to-test size/small Small and simple task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deployment: Create a stable overlay for kata-deploy
4 participants
@zvonkok @fidencio @gkurz @katacontainersbot