metrics: cleans k8s iperf deployment when the test finishes. #8542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dborquez
added
no-backport-needed
area/metrics
dborquez
force-pushed
the
metrics_fix_deployment_cleaning
branch
from
8b5c8f0
to
db573d4
Compare
dborquez
force-pushed
the
metrics_fix_deployment_cleaning
branch
from
db573d4
to
c3f633c
Compare
GabyCT
approved these changes
Dec 1, 2023
|
/test |
chavafg
reviewed
Dec 7, 2023
tests/metrics/network/iperf3_kubernetes/k8s-network-metrics-iperf3.sh
Outdated
Show resolved
Hide resolved
|
|
||
| trap remove_tmp_file EXIT | ||
| if [ -z "${bandwidth_result}" ] || [ -z "${jitter_result}" ] || [ -z "${cpu_result}" ] || [ -z "${parallel_result}" ]; then | ||
| die "iperf has not results to save" |
There was a problem hiding this comment.
suggested rewording: iperf couldn't find any results to save
tests/metrics/network/iperf3_kubernetes/k8s-network-metrics-iperf3.sh
Outdated
Show resolved
Hide resolved
| metrics_json_end_array "Results" | ||
| fi | ||
| metrics_json_add_array_element "${json}" | ||
| metrics_json_end_array "Results" | ||
| } | ||
|
|
||
| function iperf3_cpu() { | ||
| # Start server |
There was a problem hiding this comment.
is this comment still relevant in this part of the function? iiuc, the iperf server is started in the iperf3_start_deployment function. I see this same comment in other functions.
There was a problem hiding this comment.
we can't get rid of this comment, thanks @chavafg
dborquez
force-pushed
the
metrics_fix_deployment_cleaning
branch
from
c3f633c
to
8fd0eb7
Compare
|
/test |
amshinde
reviewed
Dec 7, 2023
tests/metrics/network/iperf3_kubernetes/runtimeclass_workloads/iperf3-deployment.yaml
Show resolved
Hide resolved
This PR fixes small issues like: 1. Cleaning up the k8s environment by removing the iperf test implementation even when the test fails. 2. Checks if the workload returned a result before generating an empty results json file as it was bein done. 3. Removes the redundancy of calls to functions that process subtests and should compose the results json file only when all results are ready and not before. 4. The tcp service manifest was added to the server deployment which targets TCP port 5201. Fixes: kata-containers#8534 Signed-off-by: David Esparza <david.esparza.borquez@intel.com>
A prerequisite for measuring kata network bandwidth is run Iperf3 tool at a the transport layer provided by a k8s service for exposing a network where the clients inside the cluster can use to contact Pods in the service. Signed-off-by: David Esparza <david.esparza.borquez@intel.com>
dborquez
force-pushed
the
metrics_fix_deployment_cleaning
branch
from
8fd0eb7
to
b257700
Compare
|
/test |
amshinde
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes small issues like:
Fixes: #8534