libs: protection: x86_64: drop root requirement for querying #8549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fidencio
reviewed
Dec 1, 2023
| @@ -13,7 +13,7 @@ use std::path::Path; | |||
| use std::path::PathBuf; | |||
| use thiserror::Error; | |||
|
|
|||
| #[cfg(any(target_arch = "s390x", target_arch = "x86_64"))] | |||
| #[cfg(any(target_arch = "s390x", target_arch = "powerpc64le"))] | |||
There was a problem hiding this comment.
Out of curiosity, why powerpc64le was added here?
It seems not related to this commit.
There was a problem hiding this comment.
I've added a comment to the commit. Basically PPC64 needs this import fwics but it was previously missing.
It is no longer necessary to be `root` to query the guest protection (TDX) on `x86_64` systems, so drop the requirement. > **Note:** > > This change drops the `nix` `Uid` import required for the `root` check. > But at the same time it adds it for PPC64le since that implementation of > `available_guest_protection()` needs it and it was previously missing. Fixes: kata-containers#8548. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Remove the redundant `kata-ctl` `root` check when running the `env` command. This check duplicated the `GuestProtection` check, and that check is now no longer necessary anyway. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
force-pushed
the
tdx-no-root
branch
from
487b1c3
to
e1caca3
Compare
amshinde
approved these changes
Dec 1, 2023
jodh-intel
added
safe-to-test
|
/test |
jodh-intel
added
safe-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is no longer necessary to be
rootto query the guest protection(TDX) on
x86_64systems, so drop the requirement.Also update
kata-ctlto remove the duplicate, and now redundant, root check.Fixes: #8548.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com