Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: missing port type in the DeviceInfo #8552

Merged
merged 1 commit into from Feb 6, 2024
Merged

runtime: missing port type in the DeviceInfo #8552

merged 1 commit into from Feb 6, 2024

Conversation

deagon
Copy link
Contributor

@deagon deagon commented Dec 4, 2023 •
edited

Missing port type would cause error: port is not set.

kata-containers/src/runtime/pkg/device/drivers/vfio.go

Lines 74 to 78 in 852021e

// If vfio.Port is not set we bail out, users should set
// explicitly the port in the config file
if vfio.Port == "" {
return fmt.Errorf("cold_plug_vfio= or hot_plug_vfio= port is not set for device %s (BridgePort | RootPort | SwitchPort)", vfio.BDF)
}

Fix: #9014

@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Dec 4, 2023
@Apokleos Apokleos added area/runtime Issues that impact the runtime (including shimv2) area/vfio ok-to-test labels Dec 5, 2023
@deagon
Copy link
Contributor Author

deagon commented Dec 11, 2023

@zvonkok Take a review please.

@deagon
Copy link
Contributor Author

deagon commented Feb 4, 2024

@justxuewei Take a review please.

@justxuewei
Copy link
Member

The commit message is required to be updated as well.

  1. File an issue.
  2. git commit --amend
  3. Modify your commit message.
  4. git push -f

@deagon deagon requested a review from zvonkok February 4, 2024 09:03
justxuewei
justxuewei approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@justxuewei
Copy link
Member

/test

@justxuewei
Copy link
Member

Hi @deagon. Please rebase atop of main to get CI passed.

@deagon
runtime: failed to run in the case of ColdPlugVFIO
6068faf 
Add the missing port type in the DeviceInfo.

Fixes: kata-containers#9014
Signed-off-by: Guoqiang Ding <dgq8211@gmail.com>
@justxuewei
Copy link
Member

/test

@deagon
Copy link
Contributor Author

deagon commented Feb 5, 2024 

This issue has been marked for auto-backporting. Add label(s) backport-to-BRANCHNAME to backport to them

@justxuewei

@justxuewei
Copy link
Member

This issue has been marked for auto-backporting. Add label(s) backport-to-BRANCHNAME to backport to them

You could ignore this as it is a non-required item.

Apokleos
Apokleos approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@Apokleos Apokleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @deagon LGTM!

@Apokleos Apokleos merged commit 1ab9a21 into kata-containers:main Feb 6, 2024
288 of 295 checks passed
@deagon deagon deleted the fix/missing-port-type branch February 6, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justxuewei justxuewei justxuewei approved these changes

@Apokleos Apokleos Apokleos approved these changes

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees
No one assigned
Labels
area/runtime Issues that impact the runtime (including shimv2) area/vfio ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runtime: cold_plug_vfio failed
5 participants
@deagon @justxuewei @zvonkok @Apokleos @katacontainersbot