Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gha: k8s: Add cloud-hypervisor (runtime-rs) support #8560

Merged
merged 3 commits into from Dec 11, 2023
Merged

gha: k8s: Add cloud-hypervisor (runtime-rs) support #8560

merged 3 commits into from Dec 11, 2023

Conversation

GabyCT
Copy link
Contributor

@GabyCT GabyCT commented Dec 4, 2023

This PR adds the Cloud Hypervisor driver, integrated with the runtime-rs, as part of the kubernetes tests.

Fixes #8559

@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Dec 4, 2023
@GabyCT
Copy link
Contributor Author

GabyCT commented Dec 5, 2023

/test

@fidencio
Copy link
Member

fidencio commented Dec 5, 2023

@GabyCT, are all the tests passing with this?
If not, or unknown, I'd recommend adding a logic to skip the tests as part of this PR, and then whenever we actually have the PR for enabling the tests we can un-skip them as part of the same series.

Please, check what I did on 05ce52d

@GabyCT
Copy link
Contributor Author

GabyCT commented Dec 5, 2023 •
edited

@fidencio so what I was thinking is that all the tests run and in case that something is failing in another PR skip the ones that are failing and open issues about that to put in each test as a reference to the issue, as the CI will be non-required it should not have a major impact if I do that

@GabyCT
gha: k8s: Add cloud-hypervisor (runtime-rs) support
acee3d8 
This PR adds the Cloud Hypervisor driver, integrated with the runtime-rs,
as part of the kubernetes tests.

Fixes kata-containers#8559

Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
@GabyCT
tests: Enable but do not run k8s tests for cloud hypervisor
33b3004 
This PR enables but do not run k8s tests for cloud hypervisor
for runtime-rs.

Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
@GabyCT
tests: Fix indentation of gha-run script
ce694b9 
This PR fixes the indentation of gha run script.

Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
@katacontainersbot katacontainersbot added size/large Task of significant size and removed size/tiny Smallest and simplest task labels Dec 7, 2023
@GabyCT
Copy link
Contributor Author

GabyCT commented Dec 7, 2023

@fidencio changes applied

fidencio
fidencio approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @GabyCT!

@GabyCT
Copy link
Contributor Author

GabyCT commented Dec 7, 2023

/test

jodh-intel
jodh-intel approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GabyCT.

lgtm

@jodh-intel jodh-intel added wip Work in Progress (PR incomplete - needs more work or rework) and removed wip Work in Progress (PR incomplete - needs more work or rework) labels Dec 11, 2023
@GabyCT GabyCT merged commit 43410e1 into kata-containers:main Dec 11, 2023
290 of 311 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fidencio fidencio fidencio approved these changes

@jodh-intel jodh-intel jodh-intel approved these changes

Assignees
No one assigned
Labels
ok-to-test size/large Task of significant size
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gha: k8s: Add cloud-hypervisor (runtime-rs) support
4 participants
@GabyCT @fidencio @jodh-intel @katacontainersbot